Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()

Sudip Mukherjee
2015-05-13T04:46:05Z

On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 09:49, Sudip Mukherjee wrote:
> > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>
> You're running checkpatch --strict right?
>
> > 1) multiple blank lines
> > 2) Blank lines aren't necessary before a close brace
> > 3) spaces preferred around that '+'
>
> I will fix them (as they're pretty straightforward), and will
> probably do --strict checks for my patches in future;
I think --strict is the suggested way of checking.
And if i remember correctly it was once discussed to make --strict the
default mode, but I think that was never done.
>
> I will not fix more complex checks in such cases, because patch like this
> was supposed to simplify function (i.e. split it) - without changing
> it's code too much.
>
> Is it ok with you?
ofcourse, checkpatch also complained about many other things, but they
will need separate patch to correct.

regards
sudip
>
> Regards,
> Mateusz
>