Re: [PATCH v3 02/33] staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings

Mateusz Kulikowski
2015-05-12T19:52:10Z

On 10.05.2015 15:19, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
>> Replace memcpy() with ether_addr_copy() where possible to make
>> checkpatch.pl happy.
>
> I need proof that this is ok to do, please provide that in the changelog
> entry.

What kind of proof do you expect?

I've added BUG into ether_addr_copy (on unaligned addresses) and did some basic
networking tests (pings using WPA2/CCMP AP). Of course I haven't done 100% coverage
test to driver.

Additionally I manually analyzed code (although human errors are possible).

Do you want me to run some static analyzer as well? Or are this two enough
(just add them to changelog).

Regards,
Mateusz