From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753586AbbEKLEe (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2015 07:04:34 -0400
Received: from foss.arm.com ([217.140.101.70]:57762 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752224AbbEKLEc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2015 07:04:32 -0400
Date: Mon, 11 May 2015 12:04:22 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
        Kumar Gala <galak@codeaurora.org>,
        Pratik Patel <pratikp@codeaurora.org>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <Pawel.Moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components
Message-ID: <20150511110422.GA4595@leverpostej>
References: <1431012969-16338-1-git-send-email-ivan.ivanov@linaro.org>
 <1431012969-16338-3-git-send-email-ivan.ivanov@linaro.org>
 <CANLsYkzNXBH0d6v1Ny_JwpW6NcKr9v0oAi9K3YfipwDgHWfMMA@mail.gmail.com>
 <1431092877.21307.18.camel@linaro.org>
 <20150508180052.GD11680@leverpostej>
 <B19B6A91-0CF2-428B-8CAC-FFEDD5D3D094@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <B19B6A91-0CF2-428B-8CAC-FFEDD5D3D094@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 08, 2015 at 07:17:12PM +0100, Ivan T. Ivanov wrote:
> 
> > On May 8, 2015, at 9:00 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > 
> > On Fri, May 08, 2015 at 02:47:57PM +0100, Ivan T. Ivanov wrote:
> >> 
> >> On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote:
> >>> On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote:
> >>>> Add initial set of CoreSight components found on Qualcomm's 8x16 chipset.
> >>>> 
> >>>> 
> >>>> +       replicator@824000 {
> >>>> +               compatible = "qcom,coresight-replicator", "arm,primecell";
> >>> 
> >>> Shouldn't it be "qcom,coresight-replicator1x" ?
> >>> 
> >> 
> >> 
> >> 
> >> True, I still wonder, why we have to have this compatible string? 
> >> Drivers are probed by amba_id and "arm,primecell", after all.
> > 
> > The compatible string tells you both the device _and_ the format of the
> > other properties, because it tells you which binding applies.
> > 
> > So the compatible string should be present regardless, as
> > "arm,primecell" does not define the majority of the properties you need
> > for the replicator node.
> 
> Mmm, only if vendors don’t bother to update version information
> fused to revision id registers, which happens. And this could 
> be workaround by "arm,primecell-periphid”, no?

No. That only tells you the identity of the device, not the format of
the binding.

Thanks,
Mark.