From: Joerg Roedel <jroedel@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>, Gleb Natapov <gleb@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] kvm: irqchip: Break up high order allocations of kvm_irq_routing_table
Date: Mon, 11 May 2015 13:25:22 +0200 [thread overview]
Message-ID: <20150511112522.GJ5438@suse.de> (raw)
In-Reply-To: <554CE3A5.7000101@redhat.com>
Hi Paolo,
On Fri, May 08, 2015 at 06:26:13PM +0200, Paolo Bonzini wrote:
> It probably doesn't matter much indeed, but can you time the difference?
> kvm_set_irq_routing is not too frequent, but happens enough often that
> we had to use a separate SRCU instance just to speed it up (see commit
> 719d93cd5f5, kvm/irqchip: Speed up KVM_SET_GSI_ROUTING, 2014-01-16).
The results vary a lot, but what I can say for sure is that the
kvm_set_irq_routing function takes at least twice as long (~10.000 vs
~22.000 cycles) as before on my AMD Kaveri machine (maximum was between
3-4 times as long).
On the other side this function is only called 2 times at boot in my
test, so I couldn't detect a noticable effect on the overall boot time
of the guest (37 disks were attached).
Joerg
next prev parent reply other threads:[~2015-05-11 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 12:31 [PATCH] kvm: irqchip: Break up high order allocations of kvm_irq_routing_table Joerg Roedel
2015-05-08 16:26 ` Paolo Bonzini
2015-05-11 11:25 ` Joerg Roedel [this message]
2015-05-11 11:45 ` Paolo Bonzini
2015-05-11 12:50 ` Christian Borntraeger
2015-05-11 12:53 ` Christian Borntraeger
2015-05-11 13:27 ` Paolo Bonzini
2015-06-05 10:50 ` Joerg Roedel
2015-06-05 11:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511112522.GJ5438@suse.de \
--to=jroedel@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=gleb@kernel.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox