From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: remove unused variable
Date: Mon, 11 May 2015 14:31:02 +0300 [thread overview]
Message-ID: <20150511113102.GK14154@mwanda> (raw)
In-Reply-To: <1431341230-29639-1-git-send-email-sudipm.mukherjee@gmail.com>
On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
> there variables were not used anywhere and was showing as build warning.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/staging/lustre/lustre/lov/lov_request.c | 4 +---
> drivers/staging/lustre/lustre/obdclass/acl.c | 1 -
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
> index f6e1314..d24ba8e 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_request.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_request.c
> @@ -74,10 +74,8 @@ void lov_finish_set(struct lov_request_set *set)
> kfree(req);
> }
>
> - if (set->set_pga) {
> - int len = set->set_oabufs * sizeof(*set->set_pga);
> + if (set->set_pga)
> OBD_FREE_LARGE(set->set_pga, len);
^^^
It's used right here?
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-11 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 10:47 [PATCH] staging: lustre: remove unused variable Sudip Mukherjee
2015-05-11 11:31 ` Dan Carpenter [this message]
2015-05-11 11:43 ` Sudip Mukherjee
2015-05-11 11:53 ` Drokin, Oleg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511113102.GK14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox