From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752908AbbEKLoG (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2015 07:44:06 -0400
Received: from mail-pd0-f175.google.com ([209.85.192.175]:33729 "EHLO
	mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750829AbbEKLoD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2015 07:44:03 -0400
Date: Mon, 11 May 2015 17:13:53 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: remove unused variable
Message-ID: <20150511114330.GA11994@sudip-PC>
References: <1431341230-29639-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20150511113102.GK14154@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150511113102.GK14154@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
> > -	if (set->set_pga) {
> > -		int len = set->set_oabufs * sizeof(*set->set_pga);
> > +	if (set->set_pga)
> >  		OBD_FREE_LARGE(set->set_pga, len);
>                                              ^^^
> It's used right here?

oops.. sorry .. but why i didnot get a build failure after this?

ok, got it ...  

#define OBD_FREE_LARGE(ptr, size)	\
do {					\
		kvfree(ptr);		\
} while (0)

the variable is actually not used. I will make a v2 and send 
tomorrow. today is a day of silly mistakes :( 

regards
sudip

> 
> regards,
> dan carpenter
>