Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()

Mateusz Kulikowski
2015-05-12T20:46:52Z

On 11.05.2015 15:48, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> + if (info_element->len >= 4 &&
>> + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
>> + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) {
>
>
> This if statement was actually easier to read in the original code:
>
> if (info_element->len >= 4 &&
> info_element->data[0] == 0x00 &&
> info_element->data[1] == 0x50 &&
> info_element->data[2] == 0xf2 &&
> info_element->data[3] == 0x01) {
>
> Your eye can immediately spot the bits which are different on each line
> when they are lined up like that.

You're right - will fix that.

Regards,
Mateusz