Re: Re: [PATCH v3 3/3] perf probe: Show better error message when failed to find variable

Arnaldo Carvalho de Melo
2015-05-11T13:46:30Z

Em Mon, May 11, 2015 at 09:02:47PM +0900, Masami Hiramatsu escreveu:
> On 2015/05/11 19:15, He Kuang wrote:
> > On 2015/5/11 17:50, Ingo Molnar wrote:
> >> * He Kuang <hekuang@huawei.com> wrote:
> >>> On 2015/5/11 17:30, Ingo Molnar wrote:
> >>>>> After this patch:
> >>>>> $ perf probe --add 'generic_perform_write+118 bytes'
> >>>>> Failed to find the location of bytes at this address.
> >>>> What does this sentence mean? I thought 'address' means 'location of
> >>>> bytes'. So the address identifies the location and obviously we know
> >>>> that. So this message wants to say something else.
> >>> 'generic_perform_write' is a function name, while 'bytes' is a local
> >>> variable in this function. Maybe the variable I chose make you confused.

> >>> This maybe clear:
> >>> Failed to find the location of 'bytes' at this address.
> >> Yeah, absolutely! This highlights the importance of putting
> >> user-supplied symbols into quotes and such.

> >> Maybe even write:

> >> Failed to find the location of the 'bytes' variable at this address.

> OK, He, could you also include this fix?

I agree with the change, makes things clearer, will do the change
myself. If He has any objection to that, I can fix things up before
pushing it to Ingo,

Thanks,

- Arnaldo