From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbEKNgU (ORCPT ); Mon, 11 May 2015 09:36:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbEKNgR (ORCPT ); Mon, 11 May 2015 09:36:17 -0400 Date: Mon, 11 May 2015 15:36:04 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: "Naveen N. Rao" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF Message-ID: <20150511133604.GE13337@krava.redhat.com> References: <1430306131-6780-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <20150508194404.GS7862@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150508194404.GS7862@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2015 at 04:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu: > > We get a linker error if we try to build with NO_DWARF since we build > > util/unwind-libdw.c, but do not include -ldw > > Thanks, applied, but adding Jiri to the CC list, lets see if he pokes > some hole on this one... it seems reasonable ;-) ack jirka > > - Arnaldo > > > Signed-off-by: Naveen N. Rao > > --- > > tools/perf/config/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > > index 59a98c6..d47c4dc 100644 > > --- a/tools/perf/config/Makefile > > +++ b/tools/perf/config/Makefile > > @@ -268,6 +268,10 @@ else > > endif # libelf support > > endif # NO_LIBELF > > > > +ifdef NO_DWARF > > + NO_LIBDW_DWARF_UNWIND := 1 > > +endif > > + > > ifndef NO_LIBELF > > CFLAGS += -DHAVE_LIBELF_SUPPORT > > EXTLIBS += -lelf > > -- > > 2.3.5