* [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF @ 2015-04-29 11:15 Naveen N. Rao 2015-05-08 19:44 ` Arnaldo Carvalho de Melo 2015-05-10 7:12 ` [tip:perf/core] " tip-bot for Naveen N. Rao 0 siblings, 2 replies; 6+ messages in thread From: Naveen N. Rao @ 2015-04-29 11:15 UTC (permalink / raw) To: acme; +Cc: linux-kernel We get a linker error if we try to build with NO_DWARF since we build util/unwind-libdw.c, but do not include -ldw Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> --- tools/perf/config/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 59a98c6..d47c4dc 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -268,6 +268,10 @@ else endif # libelf support endif # NO_LIBELF +ifdef NO_DWARF + NO_LIBDW_DWARF_UNWIND := 1 +endif + ifndef NO_LIBELF CFLAGS += -DHAVE_LIBELF_SUPPORT EXTLIBS += -lelf -- 2.3.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF 2015-04-29 11:15 [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF Naveen N. Rao @ 2015-05-08 19:44 ` Arnaldo Carvalho de Melo 2015-05-11 13:36 ` Jiri Olsa 2015-05-10 7:12 ` [tip:perf/core] " tip-bot for Naveen N. Rao 1 sibling, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-05-08 19:44 UTC (permalink / raw) To: Naveen N. Rao; +Cc: linux-kernel, Jiri Olsa Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu: > We get a linker error if we try to build with NO_DWARF since we build > util/unwind-libdw.c, but do not include -ldw Thanks, applied, but adding Jiri to the CC list, lets see if he pokes some hole on this one... - Arnaldo > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > --- > tools/perf/config/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 59a98c6..d47c4dc 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -268,6 +268,10 @@ else > endif # libelf support > endif # NO_LIBELF > > +ifdef NO_DWARF > + NO_LIBDW_DWARF_UNWIND := 1 > +endif > + > ifndef NO_LIBELF > CFLAGS += -DHAVE_LIBELF_SUPPORT > EXTLIBS += -lelf > -- > 2.3.5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF 2015-05-08 19:44 ` Arnaldo Carvalho de Melo @ 2015-05-11 13:36 ` Jiri Olsa 2015-05-11 14:01 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: Jiri Olsa @ 2015-05-11 13:36 UTC (permalink / raw) To: Arnaldo Carvalho de Melo; +Cc: Naveen N. Rao, linux-kernel On Fri, May 08, 2015 at 04:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu: > > We get a linker error if we try to build with NO_DWARF since we build > > util/unwind-libdw.c, but do not include -ldw > > Thanks, applied, but adding Jiri to the CC list, lets see if he pokes > some hole on this one... it seems reasonable ;-) ack jirka > > - Arnaldo > > > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > > --- > > tools/perf/config/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > > index 59a98c6..d47c4dc 100644 > > --- a/tools/perf/config/Makefile > > +++ b/tools/perf/config/Makefile > > @@ -268,6 +268,10 @@ else > > endif # libelf support > > endif # NO_LIBELF > > > > +ifdef NO_DWARF > > + NO_LIBDW_DWARF_UNWIND := 1 > > +endif > > + > > ifndef NO_LIBELF > > CFLAGS += -DHAVE_LIBELF_SUPPORT > > EXTLIBS += -lelf > > -- > > 2.3.5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF 2015-05-11 13:36 ` Jiri Olsa @ 2015-05-11 14:01 ` Arnaldo Carvalho de Melo 2015-05-11 16:03 ` Naveen N. Rao 0 siblings, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-05-11 14:01 UTC (permalink / raw) To: Jiri Olsa; +Cc: Naveen N. Rao, linux-kernel Em Mon, May 11, 2015 at 03:36:04PM +0200, Jiri Olsa escreveu: > On Fri, May 08, 2015 at 04:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu: > > > We get a linker error if we try to build with NO_DWARF since we build > > > util/unwind-libdw.c, but do not include -ldw > > > > Thanks, applied, but adding Jiri to the CC list, lets see if he pokes > > some hole on this one... > > it seems reasonable ;-) ack Ok, thanks for the Ack, I feel relieved, already in Ingo's tree, so no time to insert your Acked-by :-) - Arnaldo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF 2015-05-11 14:01 ` Arnaldo Carvalho de Melo @ 2015-05-11 16:03 ` Naveen N. Rao 0 siblings, 0 replies; 6+ messages in thread From: Naveen N. Rao @ 2015-05-11 16:03 UTC (permalink / raw) To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, linux-kernel On 2015/05/11 11:01AM, Arnaldo Carvalho de Melo wrote: > Em Mon, May 11, 2015 at 03:36:04PM +0200, Jiri Olsa escreveu: > > On Fri, May 08, 2015 at 04:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu: > > > > We get a linker error if we try to build with NO_DWARF since we build > > > > util/unwind-libdw.c, but do not include -ldw > > > > > > Thanks, applied, but adding Jiri to the CC list, lets see if he pokes > > > some hole on this one... > > > > it seems reasonable ;-) ack Jiri, Thanks for the review. > > Ok, thanks for the Ack, I feel relieved, already in Ingo's tree, so no > time to insert your Acked-by :-) :) Arnaldo, Can you please also pick this up: http://thread.gmane.org/gmane.linux.kernel/1941352 This is the last of the fixes I have for probing on ppc. This is a generic fix though I only see it with ppc64 kernels for now. Thanks! - Naveen ^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:perf/core] perf build: Disable libdw DWARF unwind when built with NO_DWARF 2015-04-29 11:15 [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF Naveen N. Rao 2015-05-08 19:44 ` Arnaldo Carvalho de Melo @ 2015-05-10 7:12 ` tip-bot for Naveen N. Rao 1 sibling, 0 replies; 6+ messages in thread From: tip-bot for Naveen N. Rao @ 2015-05-10 7:12 UTC (permalink / raw) To: linux-tip-commits; +Cc: linux-kernel, tglx, naveen.n.rao, hpa, acme, mingo Commit-ID: 76d408498b08447e0f61dfdd611aeb6e8e61ce80 Gitweb: http://git.kernel.org/tip/76d408498b08447e0f61dfdd611aeb6e8e61ce80 Author: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> AuthorDate: Wed, 29 Apr 2015 16:45:31 +0530 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 8 May 2015 16:43:14 -0300 perf build: Disable libdw DWARF unwind when built with NO_DWARF We get a linker error if we try to build with NO_DWARF since we build util/unwind-libdw.c, but do not include -ldw Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> Link: http://lkml.kernel.org/r/1430306131-6780-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/config/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 435b6ca..1b957a1 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -268,6 +268,10 @@ else endif # libelf support endif # NO_LIBELF +ifdef NO_DWARF + NO_LIBDW_DWARF_UNWIND := 1 +endif + ifndef NO_LIBELF CFLAGS += -DHAVE_LIBELF_SUPPORT EXTLIBS += -lelf ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-11 16:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-29 11:15 [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF Naveen N. Rao 2015-05-08 19:44 ` Arnaldo Carvalho de Melo 2015-05-11 13:36 ` Jiri Olsa 2015-05-11 14:01 ` Arnaldo Carvalho de Melo 2015-05-11 16:03 ` Naveen N. Rao 2015-05-10 7:12 ` [tip:perf/core] " tip-bot for Naveen N. Rao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox