public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "acme@redhat.com" <acme@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>,
	David Ahern <david.ahern@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>
Subject: Re: arm/arm64 perf build issue with mainline
Date: Mon, 11 May 2015 12:59:58 -0300	[thread overview]
Message-ID: <20150511155958.GB2724@redhat.com> (raw)
In-Reply-To: <20150511155814.GA2724@redhat.com>

Em Mon, May 11, 2015 at 12:58:14PM -0300, acme@redhat.com escreveu:
> Em Mon, May 11, 2015 at 02:33:04PM +0200, Ingo Molnar escreveu:
> > > That was already proposed here (as part of the fallback from getconf):
> > > 
> > >   https://lkml.kernel.org/r/20150427190356.GD474@krava.redhat.com
> > > 
> > > but I'm not sure what happened to the patch.
> > 
> > Sending out the latest/best version as a reminder for Arnaldo will 
> > sure help it along.
> > 
> > Acked-by: Ingo Molnar <mingo@kernel.org>
> 
> IIRC it was merged already, lemme check...

Yes, only for perf/core:


[acme@zoo linux]$ git show 762abdc0c6c013425958cd9f5105f4e32268d434
commit 762abdc0c6c013425958cd9f5105f4e32268d434
Author: Will Deacon <will.deacon@arm.com>
Date:   Thu Apr 23 15:00:16 2015 +0100

    perf tools: Use getconf to determine number of online CPUs
    
    Parsing /proc/cpuinfo is a fiddly, arch-dependent business and a recent
    change to get it working for Sparc broke arm and arm64 platforms.
    
    Use sysconf to determine the number of online CPUs only parsing
    /proc/cpuinfo when sysconf is not available.
    
    Signed-off-by: Will Deacon <will.deacon@arm.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: David Ahern <david.ahern@oracle.com>
    Cc: Mark Rutland <Mark.Rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lkml.kernel.org/r/20150423140454.GJ1652@arm.com
    [ Made it fall back to parsing /proc when getconf not found ]
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index c699dc35eef9..d31a7bbd7cee 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -24,7 +24,7 @@ unexport MAKEFLAGS
 # (To override it, run 'make JOBS=1' and similar.)
 #
 ifeq ($(JOBS),)
-  JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null)
+  JOBS := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null)
   ifeq ($(JOBS),0)
     JOBS := 1
   endif
[acme@zoo linux]$ 

  reply	other threads:[~2015-05-11 16:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 11:29 arm/arm64 perf build issue with mainline Will Deacon
2015-04-23 14:04 ` Will Deacon
2015-04-23 14:16   ` David Ahern
2015-04-24 16:10     ` Arnaldo Carvalho de Melo
2015-04-24 16:22       ` Will Deacon
2015-04-24 17:21         ` David Ahern
2015-04-27 16:26           ` Arnaldo Carvalho de Melo
2015-04-27 17:13             ` David Ahern
2015-04-27 17:40               ` Arnaldo Carvalho de Melo
2015-04-27 17:49                 ` Jiri Olsa
2015-04-27 18:39                   ` Arnaldo Carvalho de Melo
2015-04-27 18:41                     ` Jiri Olsa
2015-04-27 18:45                       ` Arnaldo Carvalho de Melo
2015-04-27 18:52                         ` Jiri Olsa
2015-04-27 19:00                           ` Arnaldo Carvalho de Melo
2015-04-27 19:03                             ` Jiri Olsa
2015-05-06  3:09   ` [tip:perf/core] perf tools: Use getconf to determine number of online CPUs tip-bot for Will Deacon
2015-05-13  6:24   ` [tip:perf/urgent] " tip-bot for Will Deacon
2015-04-23 14:29 ` arm/arm64 perf build issue with mainline David Ahern
2015-05-11  8:21   ` Ingo Molnar
2015-05-11 12:31     ` Will Deacon
2015-05-11 12:33       ` Ingo Molnar
2015-05-11 15:58         ` acme
2015-05-11 15:59           ` acme [this message]
2015-05-11 17:29             ` Will Deacon
2015-05-11 19:01               ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511155958.GB2724@redhat.com \
    --to=acme@redhat.com \
    --cc=Mark.Rutland@arm.com \
    --cc=david.ahern@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox