The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Michal Hocko <mhocko@suse.cz>,
	Josh Triplett <josh@joshtriplett.org>,
	Vladimir Davydov <vdavydov@parallels.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Bertrand Jacquin <beber@meleeweb.net>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Iulia Manda <iulia.manda21@gmail.com>,
	Pranith Kumar <bobby.prani@gmail.com>,
	Clark Williams <clark.williams@gmail.com>,
	Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu
Date: Mon, 11 May 2015 11:13:28 -0700	[thread overview]
Message-ID: <20150511181327.GA1884@jtriplet-mobl1> (raw)

Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
!CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
longer hidden with !EXPERT, but left it in the middle of the EXPERT
menu.  menuconfig stops putting config items under a submenu once it
encounters an item that doesn't depend on the menu's config item, so
this caused the remainder of the EXPERT menu to spill out into the
containing menu around it.  Fix by moving BPF_SYSCALL before the EXPERT
menu, next to BPF.

Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---

Ingo, do you want to take this through -tip?  Or should this go through some
other tree?

I'm also thinking about splitting the entire EXPERT menu into a separate
Kconfig.expert and including it from init/Kconfig, to make it clear that
everything in that menu should only be visible if EXPERT.  Right now, the long
EXPERT menu blends into the longer init/Kconfig, and issues like this happen
every few kernel releases.

 init/Kconfig | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index dc24dec..e2f16f1 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1341,6 +1341,16 @@ config HAVE_PCSPKR_PLATFORM
 config BPF
 	bool
 
+# syscall, maps, verifier
+config BPF_SYSCALL
+	bool "Enable bpf() system call"
+	select ANON_INODES
+	select BPF
+	default n
+	help
+	  Enable the bpf() system call that allows to manipulate eBPF
+	  programs and maps via file descriptors.
+
 menuconfig EXPERT
 	bool "Configure standard kernel features (expert users)"
 	# Unhide debug options, to make the on-by-default options visible
@@ -1535,16 +1545,6 @@ config EVENTFD
 
 	  If unsure, say Y.
 
-# syscall, maps, verifier
-config BPF_SYSCALL
-	bool "Enable bpf() system call"
-	select ANON_INODES
-	select BPF
-	default n
-	help
-	  Enable the bpf() system call that allows to manipulate eBPF
-	  programs and maps via file descriptors.
-
 config SHMEM
 	bool "Use full shmem filesystem" if EXPERT
 	default y
-- 
2.1.4


             reply	other threads:[~2015-05-11 18:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 18:13 Josh Triplett [this message]
2015-05-11 18:23 ` [PATCH] init/Kconfig: Fix break in middle of EXPERT menu Randy Dunlap
2015-05-11 20:23 ` [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert Josh Triplett
2015-05-11 21:01   ` Paul Bolle
2015-05-11 21:18     ` Josh Triplett
2015-05-11 21:32       ` Paul Bolle
2015-05-11 21:47         ` Josh Triplett
2015-05-11 22:01           ` Paul Bolle
2015-05-11 22:40             ` Josh Triplett
2015-05-11 21:50   ` Paul Bolle
2015-05-11 22:04     ` Josh Triplett
2015-05-11 22:15       ` Paul Bolle
2015-05-28  8:13         ` Paul Bolle
2015-05-11 22:36   ` Luis R. Rodriguez
2015-05-11 22:51     ` Josh Triplett
2015-05-12  7:04 ` [PATCH] init/Kconfig: Fix break in middle of EXPERT menu Ingo Molnar
2015-05-12  7:08   ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511181327.GA1884@jtriplet-mobl1 \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=beber@meleeweb.net \
    --cc=bobby.prani@gmail.com \
    --cc=clark.williams@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hannes@cmpxchg.org \
    --cc=iulia.manda21@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mcgrof@suse.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox