Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu

[Ingo Molnar <mingo@kernel.org>]

* Josh Triplett <josh@joshtriplett.org> wrote:

> Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
> !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
> longer hidden with !EXPERT, but left it in the middle of the EXPERT
> menu.  menuconfig stops putting config items under a submenu once it
> encounters an item that doesn't depend on the menu's config item, so
> this caused the remainder of the EXPERT menu to spill out into the
> containing menu around it.  Fix by moving BPF_SYSCALL before the EXPERT
> menu, next to BPF.
> 
> Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> 
> Ingo, do you want to take this through -tip?  Or should this go 
> through some other tree?

I can pick it up, but -mm might be better suited for this, if you do:

> I'm also thinking about splitting the entire EXPERT menu into a 
> separate Kconfig.expert and including it from init/Kconfig, to make 
> it clear that everything in that menu should only be visible if 
> EXPERT.  Right now, the long EXPERT menu blends into the longer 
> init/Kconfig, and issues like this happen every few kernel releases.

That's a good idea as well.

Thanks,

	Ingo