From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752673AbbELHJO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 03:09:14 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51439 "EHLO
	relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752614AbbELHJK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 03:09:10 -0400
X-Originating-IP: 50.43.43.179
Date: Tue, 12 May 2015 00:08:58 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Michal Hocko <mhocko@suse.cz>,
        Vladimir Davydov <vdavydov@parallels.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Bertrand Jacquin <beber@meleeweb.net>,
        "Luis R. Rodriguez" <mcgrof@suse.com>,
        Iulia Manda <iulia.manda21@gmail.com>,
        Pranith Kumar <bobby.prani@gmail.com>,
        Clark Williams <clark.williams@gmail.com>,
        Mel Gorman <mgorman@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/Kconfig: Fix break in middle of EXPERT menu
Message-ID: <20150512070857.GB8814@x>
References: <20150511181327.GA1884@jtriplet-mobl1>
 <20150512070455.GB30476@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150512070455.GB30476@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 12, 2015 at 09:04:55AM +0200, Ingo Molnar wrote:
> 
> * Josh Triplett <josh@joshtriplett.org> wrote:
> 
> > Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
> > !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
> > longer hidden with !EXPERT, but left it in the middle of the EXPERT
> > menu.  menuconfig stops putting config items under a submenu once it
> > encounters an item that doesn't depend on the menu's config item, so
> > this caused the remainder of the EXPERT menu to spill out into the
> > containing menu around it.  Fix by moving BPF_SYSCALL before the EXPERT
> > menu, next to BPF.
> > 
> > Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
> > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> > 
> > Ingo, do you want to take this through -tip?  Or should this go 
> > through some other tree?
> 
> I can pick it up, but -mm might be better suited for this, if you do:

Fair enough.

> > I'm also thinking about splitting the entire EXPERT menu into a 
> > separate Kconfig.expert and including it from init/Kconfig, to make 
> > it clear that everything in that menu should only be visible if 
> > EXPERT.  Right now, the long EXPERT menu blends into the longer 
> > init/Kconfig, and issues like this happen every few kernel releases.
> 
> That's a good idea as well.

I did so, in a patch later in this thread.

- Josh Triplett