From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbbELH2D (ORCPT ); Tue, 12 May 2015 03:28:03 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:33035 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbbELH16 (ORCPT ); Tue, 12 May 2015 03:27:58 -0400 Date: Tue, 12 May 2015 12:57:54 +0530 From: Viresh Kumar To: Sudeep Holla Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Medhurst , "Rafael J. Wysocki" Subject: Re: [PATCH] cpufreq: arm_big_little: remove compile-time dependency on BL_SWITCHER Message-ID: <20150512072754.GF32300@linux> References: <1431343473-9915-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431343473-9915-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-05-15, 12:24, Sudeep Holla wrote: > With the addition of switcher code, there's compile-time dependency on > BL_SWITCHER to get arm_big_little driver compiling on ARM64. Since ARM64 The Kconfig dependency isn't on the switcher but big.LITTLE, which isn't defined for arm64. So, we need a bit of clarity here. > @@ -562,8 +580,7 @@ int bL_cpufreq_register(struct cpufreq_arm_bL_ops *ops) > > arm_bL_ops = ops; > > - ret = bL_switcher_get_enabled(); > - set_switching_enabled(ret); > + set_switching_enabled(bL_switcher_get_enabled()); This change wasn't required.