public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Alexei Starovoitov <ast@plumgrid.com>,
	Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: force inlining of atomic ops
Date: Tue, 12 May 2015 11:22:54 +0200	[thread overview]
Message-ID: <20150512092254.GA10269@gmail.com> (raw)
In-Reply-To: <20150512075708.GA6969@virgo.local>


* Hagen Paul Pfeifer <hagen@jauu.net> wrote:

> * Denys Vlasenko | 2015-05-08 12:26:02 [+0200]:
> 
> [snip]
> >With both gcc 4.7.2 and 4.9.2, sometimes gcc mysteriously doesn't inline
> >This patch fixes this for x86 atomic ops via s/inline/__always_inline/.
> >This decreases allyesconfig kernel by about 25k:
> >
> >    text     data      bss       dec     hex filename
> >82399481 22255416 20627456 125282353 777a831 vmlinux.before
> >82375570 22255544 20627456 125258570 7774b4a vmlinux
> 
> atomic_inc, atomic_sub, atomic_add, atomic_sub_and_test, atomic_dec,
> atomic_dec_and_test, atomic_add_return, __atomic_add_unless, atomic64_add,
> atomic64_inc, atomic64_dec, atomic64_add_return
> 
> are already annotated with __always_inline. This patch will lead to merge
> conflicts someone, Ingo?

Yeah, I resolved it silently by dropping the bits that were already 
annotated as always-inline.

So we have two patches in tip:x86/asm:

  2a4e90b18c25 x86: Force inlining of atomic ops
  3462bd2adead x86/asm: Always inline atomics

that DTRT. Hopefully.

Thanks,

	Ingo

      reply	other threads:[~2015-05-12  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 10:26 [PATCH] x86: force inlining of atomic ops Denys Vlasenko
2015-05-08 13:29 ` [tip:x86/asm] x86: Force " tip-bot for Denys Vlasenko
2015-05-08 15:03 ` [PATCH] x86: force " Steven Rostedt
2015-05-12  7:57 ` Hagen Paul Pfeifer
2015-05-12  9:22   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512092254.GA10269@gmail.com \
    --to=mingo@kernel.org \
    --cc=ast@plumgrid.com \
    --cc=bp@alien8.de \
    --cc=dvlasenk@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hagen@jauu.net \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=rostedt@goodmis.org \
    --cc=wad@chromium.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox