public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Matthew Garrett <matthew.garrett@coreos.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	x86@kernel.org, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Matthew Garrett <mjg59@coreos.com>
Subject: Re: [PATCH V2] x86: Allow built-in command line to work in early kernel init
Date: Tue, 12 May 2015 11:28:21 +0200	[thread overview]
Message-ID: <20150512092821.GA10900@gmail.com> (raw)
In-Reply-To: <CAPeXnHuG6k3seK9HPYYPt=MfDt2jN2mdUhMLYye9kdZPJE-4Jg@mail.gmail.com>


* Matthew Garrett <matthew.garrett@coreos.com> wrote:

> Any feedback on this?

So I worry about:

 - the fragmented nature of it: lots of non-obvious pieces of code 
   will now be scattered all around arch/x86/.

 - the crazy #ifdefs scattered around

 - the various pieces of data scattered around

... so while I don't mind the feature in principle, but it should be 
centralized much better IMHO, made Kconfig invariant at least in its 
fragmented callbacks, with only the very strictly boot method specific 
details spelled out explicitly.

I have not thought much about how to achieve that :-/

Thanks,

	Ingo

  reply	other threads:[~2015-05-12  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 18:41 [PATCH] x86: Allow built-in command line to work in early kernel init Matthew Garrett
2015-04-09 20:25 ` [PATCH V2] " Matthew Garrett
2015-05-11 20:20   ` Matthew Garrett
2015-05-12  9:28     ` Ingo Molnar [this message]
2015-05-12 17:39       ` Matthew Garrett
2015-05-12 18:42         ` Matthew Garrett
2015-05-12 23:41           ` Yinghai Lu
2015-05-12 23:53             ` Matthew Garrett
2015-05-13  2:46               ` H. Peter Anvin
2015-05-13  3:06                 ` Matthew Garrett
  -- strict thread matches above, loose matches on Subject: below --
2015-05-19 23:09 Matthew Garrett
2015-05-20  7:42 ` Ingo Molnar
2015-05-27 23:33   ` Matthew Garrett
2015-06-03  9:24     ` Ingo Molnar
2015-06-03 16:08       ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512092821.GA10900@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@coreos.com \
    --cc=mingo@redhat.com \
    --cc=mjg59@coreos.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox