From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com
Subject: Re: [PATCH] perf probe: Ignore tail calls to probed functions
Date: Tue, 12 May 2015 10:40:41 -0300 [thread overview]
Message-ID: <20150512134041.GD29215@kernel.org> (raw)
In-Reply-To: <5542BDC5.90609@hitachi.com>
Em Fri, May 01, 2015 at 08:41:57AM +0900, Masami Hiramatsu escreveu:
> On 2015/04/30 23:58, Naveen N. Rao wrote:
> > The frame ends at 0xc0000000000bc27c. I suppose this is why this
> > particular call is a "tail" call. FWIW, systemtap seems to ignore these
> > as well and requires users to explicitly place probes at these call
> > sites if necessary. I print out the caller so that users know.
>
> Ah, OK. That is out of the function frame, thus we can't put probe on it.
> Hmm, we'd better wait for improvement of tail call support in dwarf...
> Anyway, at this point, I'm OK for ignoring the probe point.
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2015-05-12 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:42 [PATCH] perf probe: Ignore tail calls to probed functions Naveen N. Rao
2015-04-30 13:06 ` Masami Hiramatsu
2015-04-30 14:58 ` Naveen N. Rao
2015-04-30 23:41 ` Masami Hiramatsu
2015-05-12 13:40 ` Arnaldo Carvalho de Melo [this message]
2015-05-15 6:46 ` [tip:perf/core] " tip-bot for Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512134041.GD29215@kernel.org \
--to=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox