From: Mark Brown <broonie@kernel.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Brian Austin <brian.austin@cirrus.com>,
Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config
Date: Tue, 12 May 2015 18:58:07 +0100 [thread overview]
Message-ID: <20150512175807.GL3066@sirena.org.uk> (raw)
In-Reply-To: <554E8634.2010008@maciej.szmigiero.name>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote:
> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_88PM860X if MFD_88PM860X
> select SND_SOC_L3
> select SND_SOC_AB8500_CODEC if ABX500_CORE
> - select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS
> + select SND_SOC_AC97_CODEC
> select SND_SOC_AD1836 if SPI_MASTER
> select SND_SOC_AD193X_SPI if SPI_MASTER
> select SND_SOC_AD193X_I2C if I2C
No, you're missing the point of what _ALL_CODECS does - it builds
everything possible. This will break the build for systems without
AC'97 support.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-12 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 22:12 [PATCH] ASoC: codecs-ac97: make selectable in config Maciej S. Szmigiero
2015-05-12 17:58 ` Mark Brown [this message]
2015-05-13 20:57 ` Maciej S. Szmigiero
2015-05-14 17:53 ` Mark Brown
2015-05-14 18:46 ` Lars-Peter Clausen
2015-05-14 19:10 ` Mark Brown
2015-05-14 19:24 ` Lars-Peter Clausen
2015-05-14 19:28 ` Mark Brown
2015-05-14 19:38 ` Lars-Peter Clausen
2015-05-14 19:43 ` Mark Brown
2015-05-22 12:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512175807.GL3066@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox