From: Mark Brown <broonie@kernel.org>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: nicoleotsuka@gmail.com, timur@tabi.org, Xiubo.Lee@gmail.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode
Date: Tue, 12 May 2015 19:42:37 +0100 [thread overview]
Message-ID: <20150512184237.GP3066@sirena.org.uk> (raw)
In-Reply-To: <1431339894-4248-2-git-send-email-zidan.wang@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Mon, May 11, 2015 at 06:24:42PM +0800, Zidan Wang wrote:
> if (!sai->is_slave_mode) {
> + slot_width = sai->slot_width;
> ret = fsl_sai_set_bclk(cpu_dai, tx,
> - 2 * word_width * params_rate(params));
> + sai->slots * slot_width * params_rate(params));
> if (ret)
This seems to make TDM configuration mandatory which seems like a step
back - if it's been set up then of course we need to use it but if it's
not been configured we should be able to just infer something from
hw_params as we have been doing. Checking to see if the relevant values
have been set and falling back to using hw_params seems better.
Otherwise this looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-12 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 10:24 [PATCH 0/3] Add sai master mode, tdm slot operation and add some sample rate support Zidan Wang
2015-05-11 10:24 ` [PATCH 1/3] ASoC: fsl_sai: add sai master mode support Zidan Wang
2015-05-12 18:44 ` Mark Brown
2015-05-11 10:24 ` [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode Zidan Wang
2015-05-12 18:42 ` Mark Brown [this message]
2015-05-11 10:24 ` [PATCH 3/3] ASoC: fsl_sai: add 12kHz, 24kHz, 176.4kHz and 192kHz sample rate support Zidan Wang
2015-05-12 18:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512184237.GP3066@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=zidan.wang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox