public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Adrian Remonda <adrianremonda@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: Removed expression that has no effect
Date: Tue, 12 May 2015 14:19:01 -0700	[thread overview]
Message-ID: <20150512211901.GA10352@kroah.com> (raw)
In-Reply-To: <1431464634-25240-1-git-send-email-adrianremonda@gmail.com>

On Tue, May 12, 2015 at 11:03:52PM +0200, Adrian Remonda wrote:
> This patch remove a register from an '|' expression.
> It is wrong since after in the code, the variable ai_trig gets 
> written back to that register.
> 
> 
> 	modified:   drivers/staging/comedi/drivers/ni_mio_common.c

What does this line mean here?

And Hartley sent a fix for this yesterday, I haven't had a chance to
apply it yet...

thanks,

greg k-h

  reply	other threads:[~2015-05-12 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 21:03 [PATCH] Staging: comedi: Removed expression that has no effect Adrian Remonda
2015-05-12 21:19 ` Greg Kroah-Hartman [this message]
2015-05-14 13:57   ` AdrianRemonda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512211901.GA10352@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=adrianremonda@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox