From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482AbbEMHfL (ORCPT ); Wed, 13 May 2015 03:35:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54299 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbEMHfI (ORCPT ); Wed, 13 May 2015 03:35:08 -0400 Date: Wed, 13 May 2015 00:35:03 -0700 From: Stephen Boyd To: Maxime Ripard Cc: linux-kernel@vger.kernel.org, Mike Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH 1/6] clk: asm9260: Fix of_io_request_and_map error check Message-ID: <20150513073503.GA15988@codeaurora.org> References: <1430579006-32702-1-git-send-email-maxime.ripard@free-electrons.com> <1430579006-32702-2-git-send-email-maxime.ripard@free-electrons.com> <20150511194336.GH10961@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150511194336.GH10961@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11, Maxime Ripard wrote: > Mike, Stephen, > > On Sat, May 02, 2015 at 05:03:21PM +0200, Maxime Ripard wrote: > > of_io_request_and map returns an error pointer, but the current code assumes > > that on error the returned pointer will be NULL. > > > > Obviously, that makes the check completely useless. Change the test to actually > > check for the proper error code. > > > > Signed-off-by: Maxime Ripard > > Cc: Mike Turquette > > Cc: Stephen Boyd > > Cc: linux-clk@vger.kernel.org > > There doesn't seem to be a sub-maintainer for that driver, I guess it > should go through your tree? > Yep. Applied to clk-next. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project