From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbbEMMWJ (ORCPT ); Wed, 13 May 2015 08:22:09 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35448 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754651AbbEMMWF (ORCPT ); Wed, 13 May 2015 08:22:05 -0400 Date: Wed, 13 May 2015 13:22:00 +0100 From: Lee Jones To: Charles Keepax Cc: broonie@kernel.org, lgirdwood@gmail.com, sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v3 10/10] mfd: wm5110: Add delay before releasing reset line Message-ID: <20150513122200.GU3394@x1> References: <1431349090-24173-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1431349090-24173-11-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431349090-24173-11-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 May 2015, Charles Keepax wrote: > On the wm5110 it is important the reset line is held for slightly longer > to ensure the device starts up well. This patch adds a 5mS delay for > this. > > Signed-off-by: Charles Keepax > Acked-by: Lee Jones > --- > drivers/mfd/arizona-core.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index f1ff68a..93e4d94 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -259,6 +259,16 @@ static inline void arizona_enable_reset(struct arizona *arizona) > static void arizona_disable_reset(struct arizona *arizona) > { > if (arizona->pdata.reset) { > + switch (arizona->type) { > + case WM5110: > + case WM8280: > + /* Meet requirements for minimum reset duration */ > + msleep(5); > + break; > + default: > + break; > + } > + > gpio_set_value_cansleep(arizona->pdata.reset, 1); > msleep(1); > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog