Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

Mark Brown
2015-05-06T11:49:05Z

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Wed, May 06, 2015 at 10:24:05AM +0100, Richard Fitzgerald wrote:

> No, I'm just saying I don't see how calling the mux positions "IN1AL"
> is any clearer than calling them "A" and "B". The "IN1AL" names of the
> DAPM widgets is purely an internal detail that you wouldn't see through
> the ALSA interface anyway so they don't relate any more closely to what
> Joe user is seeing in the control list. The IN1L mux is for IN1L
> so including that information in the mux position is redundant. For me

Providing that people remember that this is what's going on here and
that they remember that for this mux this shortened name is used rather
than the full one. We're relatively consistent in doing this for most
drivers, it's helpful that "I want to connect X to Y" usually translates
directly into one of "amixer cset X Y" or "amixer cset 'X Y' on".

> the real benefit of the "A"/"B" naming is that if you're reading through
> a configuration script and saw something like

> 'IN1L Mux' = 'B'
> 'IN1R Mux' = 'B'

> It's much more readably obvious that both channels are set the same
> rather than

Right, but as I said on the initial version in the case where you care
the user probably shouldn't have the ability to set them independently
in the first place.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]