From: Matthew Wilcox <willy@linux.intel.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block:Change the function,nvme_alloc_queue to use -ENOMEM for when failing memory allocations
Date: Wed, 13 May 2015 09:32:52 -0400 [thread overview]
Message-ID: <20150513133252.GW4003@linux.intel.com> (raw)
In-Reply-To: <1431474691-30469-1-git-send-email-xerofoify@gmail.com>
On Tue, May 12, 2015 at 07:51:31PM -0400, Nicholas Krause wrote:
> This changes the function,nvme_alloc_queue to use the kernel code,
> -ENOMEM for when failing to allocate the memory required for the
> nvme_queue structure pointer,nvme in order to correctly return
> to the caller the correct reason for this function's failing.
> if (!nvmeq)
> - return NULL;
> + return -ENOMEM;
>
You didn't even compile-test this, did you?
next parent reply other threads:[~2015-05-13 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431474691-30469-1-git-send-email-xerofoify@gmail.com>
2015-05-13 13:32 ` Matthew Wilcox [this message]
2015-05-13 14:12 ` [PATCH] block:Change the function, nvme_alloc_queue to use -ENOMEM for when failing memory allocations Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513133252.GW4003@linux.intel.com \
--to=willy@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox