From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933511AbbENQTR (ORCPT ); Thu, 14 May 2015 12:19:17 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:33098 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933239AbbENQTL (ORCPT ); Thu, 14 May 2015 12:19:11 -0400 Date: Thu, 14 May 2015 09:19:13 -0700 From: Stephen Hemminger To: "Hans J. Koch" , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: [PATCH] uio: don't free irq that was not requested Message-ID: <20150514091913.46cd2b94@urahara> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org UIO base driver should only free_irq that it has requested. UIO supports drivers without interrupts (irq == 0) or custom handlers. This fixes warnings like: WARNING: CPU: 1 PID: 5478 at kernel/irq/manage.c:1244 __free_irq+0xa9/0x1e0() Trying to free already-free IRQ 0 Signed-off-by: Stephen Hemminger --- a/drivers/uio/uio.c 2015-05-14 09:04:54.677283462 -0700 +++ b/drivers/uio/uio.c 2015-05-14 09:09:28.170547587 -0700 @@ -879,7 +879,8 @@ void uio_unregister_device(struct uio_in uio_dev_del_attributes(idev); - free_irq(idev->info->irq, idev); + if (info->irq && info->irq != UIO_IRQ_CUSTOM) + free_irq(info->irq, idev); device_destroy(&uio_class, MKDEV(uio_major, idev->minor));