From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
a.p.zijlstra@chello.nl, wangnan0@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins
Date: Thu, 14 May 2015 15:33:36 +0200 [thread overview]
Message-ID: <20150514133336.GA24795@krava.redhat.com> (raw)
In-Reply-To: <1431412917-101336-1-git-send-email-hekuang@huawei.com>
On Tue, May 12, 2015 at 06:41:56AM +0000, He Kuang wrote:
SNIP
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 03409cc..338c426 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -172,6 +172,7 @@ endif
>
> LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> export LIBTRACEEVENT
> +LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list
>
> LIBAPI = $(LIB_PATH)libapi.a
> export LIBAPI
> @@ -278,8 +279,9 @@ build := -f $(srctree)/tools/build/Makefile.build dir=. obj
> $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE
> $(Q)$(MAKE) $(build)=perf
>
> -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN)
> - $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o $@
> +LD_LIBTRACEEVENT_FLAGS += -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)
Could you please just update LDFLAGS directly? I dont think
there's a need for separated variable..
otherwise it seems ok to me
thanks,
jirka
prev parent reply other threads:[~2015-05-14 13:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 6:41 [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins He Kuang
2015-05-12 6:41 ` [PATCH v2 2/2] tools lib traceevent: Ignore libtrace-dynamic-list file He Kuang
2015-05-12 12:37 ` [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins Jiri Olsa
2015-05-12 15:25 ` hekuang
2015-05-13 14:50 ` Jiri Olsa
2015-05-14 12:56 ` He Kuang
2015-05-14 13:31 ` Jiri Olsa
2015-05-15 8:01 ` He Kuang
2015-05-14 13:33 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514133336.GA24795@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox