From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH] drm/ttm: dma: Don't crash on memory in the vmalloc range
Date: Fri, 15 May 2015 12:48:57 +0200 [thread overview]
Message-ID: <20150515104856.GA28954@ulmo.nvidia.com> (raw)
In-Reply-To: <1431673794-16169-1-git-send-email-acourbot@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Fri, May 15, 2015 at 04:09:54PM +0900, Alexandre Courbot wrote:
> dma_alloc_coherent() can return memory in the vmalloc range.
> virt_to_page() cannot handle such addresses and crashes. This
> patch detects such cases and obtains the struct page * using
> vmalloc_to_page() instead.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This patch is a follow-up of the following discussion:
>
> https://www.marc.info/?l=dri-devel&m=141579595431254&w=3
>
> It works for me on both 32-bit and 64-bit Tegra, so I am not convinced
> that Thierry's initial change from virt_to_page() to phys_to_page() is
> still required - Thierry, can you confirm whether your patch is still
> relevant after this one?
If this works for you on both 32-bit and 64-bit Tegra I don't think the
earlier patch is still relevant and this looks indeed like a much more
appropriate solution.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-15 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 7:09 [PATCH] drm/ttm: dma: Don't crash on memory in the vmalloc range Alexandre Courbot
2015-05-15 10:48 ` Thierry Reding [this message]
2015-05-15 12:03 ` yalin wang
2015-05-15 19:55 ` Konrad Rzeszutek Wilk
2015-05-19 11:33 ` Alexandre Courbot
2015-06-01 17:28 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515104856.GA28954@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=acourbot@nvidia.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox