From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934847AbbEOPxj (ORCPT ); Fri, 15 May 2015 11:53:39 -0400 Received: from one.firstfloor.org ([193.170.194.197]:40081 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934533AbbEOPxg (ORCPT ); Fri, 15 May 2015 11:53:36 -0400 Date: Fri, 15 May 2015 17:53:34 +0200 From: Andi Kleen To: Ben Hutchings Cc: Willy Tarreau , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andy Lutomirski , Andi Kleen , Linus Torvalds , Ingo Molnar Subject: Re: [ 05/48] x86_64, switch_to(): Load TLS descriptors before switching DS and ES Message-ID: <20150515155334.GC19417@two.firstfloor.org> References: <20150515080530.510828652@1wt.eu> <1431693140.6315.109.camel@decadent.org.uk> <20150515133820.GA30744@1wt.eu> <1431699933.6315.115.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431699933.6315.115.camel@decadent.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > v2.6.32.65:arch/x86/kernel/process_64.c:425: /* Must be after DS reload */ > > If this comment is correct then the patch will cause a regression for > FPU state management. The comment was introduced by: Yes I already stated before that these super-risky patches are not stable material. -Andi > > commit 0a5ace2ab08d45cd78d7ef0067cdcd5c812ac54f > Author: Andi Kleen > Date: Thu Oct 5 18:47:22 2006 +0200 > > [PATCH] x86-64: Fix FPU corruption > > Ben. > > -- > Ben Hutchings > It is impossible to make anything foolproof because fools are so ingenious. -- ak@linux.intel.com -- Speaking for myself only.