Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

Guenter Roeck
2015-05-18T15:27:51Z

On Mon, May 18, 2015 at 02:15:01PM +0000, Opensource [Steve Twiss] wrote:
> On 15 May 2015 21:20 Guenter Roeck,
>
> > > > > +
> > > > > +/* E_WDG_WARN interrupt handler */
> > > > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data)
> > > > > +{
> > > > > + struct da9062_watchdog *wdt = data;
> > > > > +
> > > > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n");
> > > > > + return IRQ_HANDLED;
> > > > > +}
> > > > > +
> > >
> > > On 15 May 2015 13:58 Guenter Roeck wrote:
> > >
> > > [...]
> > >
> > > > >>> +
> > > > >>> + irq = platform_get_irq_byname(pdev, "WDG_WARN");
> > > > >>> + if (irq < 0) {
> > > > >>> + dev_err(wdt->hw->dev, "Failed to get IRQ.\n");
> > > > >>> + ret = irq;

Hi Steve,

Since the interrupt is optional, the driver should also not fail to load
if no interrupt is assigned to it in the first place.

On a separate note, there was a comment stating that the da9062 watchdog is
identical to the da9063 watchdog. If so, why can't you just use the da9063
watchdog driver ?

Thanks,
Guenter