From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbbERBsa (ORCPT ); Sun, 17 May 2015 21:48:30 -0400 Received: from lgeamrelo02.lge.com ([156.147.1.126]:35431 "EHLO lgeamrelo02.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbbERBsX (ORCPT ); Sun, 17 May 2015 21:48:23 -0400 X-Original-SENDERIP: 10.177.220.203 X-Original-MAILFROM: namhyung@kernel.org Date: Mon, 18 May 2015 10:38:50 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Peter Zijlstra , Paul Mackerras , David Ahern , Ingo Molnar , Jan Stancek , Frederic Weisbecker Subject: Re: [PATCH] perf tools: Fix "Command" sort_entry's cmp and collapse function Message-ID: <20150518013850.GA21663@sejong> References: <1431705268-12788-1-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1431705268-12788-1-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, CC-ing Frederic as he wrote the comm change. On Fri, May 15, 2015 at 05:54:28PM +0200, Jiri Olsa wrote: > Currently the se_cmp and se_collapse use pointer comparison, > which is ok for for testing equality of strings. It's not ok > as comparing function for rbtree insertion, because it gives > different results based on current pointer values. > > We saw test 32 (hists cumulation test) failing based on different > environment setup. Having all sort functions straightened fix the > test for us. Can you elaborate it? AFAIK comm string is shared among threads so pointer comparison and 'strcmp == 0' should have same result.. Thanks, Namhyung > > Reported-by: Jan Stancek > Link: http://lkml.kernel.org/n/tip-tklp6y27bseqjibcwn0py9up@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/sort.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index 4593f36ecc4c..09d4696fd9a1 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -89,14 +89,14 @@ static int64_t > sort__comm_cmp(struct hist_entry *left, struct hist_entry *right) > { > /* Compare the addr that should be unique among comm */ > - return comm__str(right->comm) - comm__str(left->comm); > + return strcmp(comm__str(right->comm), comm__str(left->comm)); > } > > static int64_t > sort__comm_collapse(struct hist_entry *left, struct hist_entry *right) > { > /* Compare the addr that should be unique among comm */ > - return comm__str(right->comm) - comm__str(left->comm); > + return strcmp(comm__str(right->comm), comm__str(left->comm)); > } > > static int64_t > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/