From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbbEREhV (ORCPT ); Mon, 18 May 2015 00:37:21 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36098 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbbEREhK (ORCPT ); Mon, 18 May 2015 00:37:10 -0400 Date: Mon, 18 May 2015 10:07:00 +0530 From: Sudip Mukherjee To: Amaury Denoyelle Cc: Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c Message-ID: <20150518043528.GA3547@sudip-PC> References: <1431874043-8153-1-git-send-email-amaury.denoyelle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431874043-8153-1-git-send-email-amaury.denoyelle@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote: > This patch fixes coding style errors reported by checkpatch.pl for > cb_pcidas64.c, about too long source code lines. > > Signed-off-by: Amaury Denoyelle > --- > } > > -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */ > +/* adjusts the size of hardware fifo > + * (which determines block size for dma xfers) */ This is not the style for multi-line comments. Please check CodingStyle in Documentation. > static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples) > { > > @@ -1987,8 +1990,8 @@ static unsigned int get_divisor(unsigned int ns, unsigned int flags) > > /* utility function that rounds desired timing to an achievable time, and > * sets cmd members appropriately. > - * adc paces conversions from master clock by dividing by (x + 3) where x is 24 bit number > - */ > + * adc paces conversions from master clock by dividing by (x + 3) where x is > + * 24 bit number */ same here and when you are sending just one patch, you do not need to mention [Patch 1/1] in the subject. just mention [Patch] regards sudip