* [patch] USB: devio: fix a condition in async_completed()
@ 2015-05-18 12:29 Dan Carpenter
2015-05-18 14:42 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-05-18 12:29 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hans de Goede
Cc: Alan Stern, Oliver Neukum, Chase Metzger, linux-usb, linux-kernel,
kernel-janitors
Static checkers complain that the current condition is never true. It
seems pretty likely that it's a typo and "URB" was intended instead of
"USB".
Fixes: 3d97ff63f899 ('usbdevfs: Use scatter-gather lists for large bulk transfers')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 4b0448c..986abde 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -513,7 +513,7 @@ static void async_completed(struct urb *urb)
snoop(&urb->dev->dev, "urb complete\n");
snoop_urb(urb->dev, as->userurb, urb->pipe, urb->actual_length,
as->status, COMPLETE, NULL, 0);
- if ((urb->transfer_flags & URB_DIR_MASK) == USB_DIR_IN)
+ if ((urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN)
snoop_urb_data(urb, urb->actual_length);
if (as->status < 0 && as->bulk_addr && as->status != -ECONNRESET &&
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] USB: devio: fix a condition in async_completed()
2015-05-18 12:29 [patch] USB: devio: fix a condition in async_completed() Dan Carpenter
@ 2015-05-18 14:42 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2015-05-18 14:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Hans de Goede, Oliver Neukum, Chase Metzger,
linux-usb, linux-kernel, kernel-janitors
On Mon, 18 May 2015, Dan Carpenter wrote:
> Static checkers complain that the current condition is never true. It
> seems pretty likely that it's a typo and "URB" was intended instead of
> "USB".
>
> Fixes: 3d97ff63f899 ('usbdevfs: Use scatter-gather lists for large bulk transfers')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 4b0448c..986abde 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -513,7 +513,7 @@ static void async_completed(struct urb *urb)
> snoop(&urb->dev->dev, "urb complete\n");
> snoop_urb(urb->dev, as->userurb, urb->pipe, urb->actual_length,
> as->status, COMPLETE, NULL, 0);
> - if ((urb->transfer_flags & URB_DIR_MASK) == USB_DIR_IN)
> + if ((urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN)
> snoop_urb_data(urb, urb->actual_length);
>
> if (as->status < 0 && as->bulk_addr && as->status != -ECONNRESET &&
Yes, this most certainly is a typo. Or rather, it is a copy of a typo
originally introduced in commit 0880aef49e40 (USB: usbfs_snoop: add
data logging back in).
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-18 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 12:29 [patch] USB: devio: fix a condition in async_completed() Dan Carpenter
2015-05-18 14:42 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox