From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Karel Zak <kzak@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org, util-linux@vger.kernel.org
Subject: Re: what's cooking in zram for 4.1
Date: Mon, 18 May 2015 23:40:27 +0900 [thread overview]
Message-ID: <20150518144027.GA10979@swordfish> (raw)
In-Reply-To: <20150518135552.GA3270@blaptop>
On (05/18/15 22:55), Minchan Kim wrote:
> > > Why do you need all in one file? ... to provide consistent statistics?
> > >
> >
> > yes, that's the main reason.
>
> In my side, other main reason was to reduce the number of system call
> to see statistics. It is not only syscall overhead itself but also
> causes slightly high-order allocation for kernel internal data structure
> via slab allocation which is bad on low memory situation where is
> frequent in zram-swap. Slab allocation could be fallback with 0-order
> pages but it could cause excessive page reclaim seriously since compaction
> didn't work.
> Yes, it's a one of problem of current VM but there is no reason to hesitate
> if we can avoid such problems and support consistent statistic as well.
>
true.
syscalls and corresponding error handling for each one of them were on a
list:
https://www.marc.info/?l=linux-kernel&m=142586445420298&w=2
Karel has a remarkably good codebase, so error handling would not be an
issue :-) that's why consistent stats moved forward.
in general, increasing consistency and reducing the syscall pressure are
good enough to move on.
-ss
next prev parent reply other threads:[~2015-05-18 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 4:21 what's cooking in zram for 4.1 Sergey Senozhatsky
2015-05-11 11:38 ` Karel Zak
2015-05-11 11:56 ` Sergey Senozhatsky
2015-05-18 13:55 ` Minchan Kim
2015-05-18 14:40 ` Sergey Senozhatsky [this message]
2015-05-18 9:36 ` Karel Zak
2015-05-18 9:56 ` Sergey Senozhatsky
2015-05-18 13:56 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518144027.GA10979@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox