From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pedro Marzo Perez <marzo.pedro@gmail.com>
Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com,
dilekuzulmez@gmail.com, joe@perches.com,
haticeerturk27@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c
Date: Mon, 18 May 2015 19:15:31 +0300 [thread overview]
Message-ID: <20150518161531.GI22558@mwanda> (raw)
In-Reply-To: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com>
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previous line.
> Removed two useless lines at ieee80211_wep_null.
>
When Joe said "Some will say this is doing too many things in a single
patch." he meant Greg. Break this up into multiple patches. Especially
now that you've added even more stuff to it.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-18 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:36 [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c Pedro Marzo Perez
2015-05-18 16:15 ` Dan Carpenter [this message]
2015-05-18 21:56 ` pmarzo
2015-05-18 20:04 ` Joe Perches
2015-05-18 22:35 ` pmarzo
2015-05-18 20:30 ` Joe Perches
2015-05-18 21:06 ` Dan Carpenter
2015-05-18 23:57 ` pmarzo
2015-05-18 16:23 ` Sudip Mukherjee
2015-05-18 21:50 ` pmarzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518161531.GI22558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haticeerturk27@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marzo.pedro@gmail.com \
--cc=navyasri.tech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox