From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932123AbbERQPz (ORCPT ); Mon, 18 May 2015 12:15:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48841 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbbERQPs (ORCPT ); Mon, 18 May 2015 12:15:48 -0400 Date: Mon, 18 May 2015 19:15:31 +0300 From: Dan Carpenter To: Pedro Marzo Perez Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c Message-ID: <20150518161531.GI22558@mwanda> References: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. > Openning braces should never be in a new line, move them to the end of > the previous line. > Removed two useless lines at ieee80211_wep_null. > When Joe said "Some will say this is doing too many things in a single patch." he meant Greg. Break this up into multiple patches. Especially now that you've added even more stuff to it. regards, dan carpenter