From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbbERQXy (ORCPT ); Mon, 18 May 2015 12:23:54 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:33909 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932127AbbERQXo (ORCPT ); Mon, 18 May 2015 12:23:44 -0400 Date: Mon, 18 May 2015 21:53:31 +0530 From: Sudip Mukherjee To: Pedro Marzo Perez Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c Message-ID: <20150518162331.GA12138@sudip-PC> References: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. > Openning braces should never be in a new line, move them to the end of > the previous line. > Removed two useless lines at ieee80211_wep_null. Like Joe Perches said in your last patch - you are doing too many things in a single patch. break it into separate patches each doing a single change. > > Signed-off-by: Pedro Marzo Perez > --- > .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 33 ++++++++-------------- > 1 file changed, 12 insertions(+), 21 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > index 0a17f84..1074916 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > @@ -9,6 +9,8 @@ > * more details. > */ > > - > + pr_debug(pr_fmt("could not allocate crypto API arc4\n")); this is not right. regards sudip