From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
"mdcasey@chabloom.com" <mdcasey@chabloom.com>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"kolbeinnkarls@gmail.com" <kolbeinnkarls@gmail.com>,
"himangi774@gmail.com" <himangi774@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Babu, Viswanathan (V.)" <vbabu3@visteon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
Date: Mon, 18 May 2015 22:12:42 +0530 [thread overview]
Message-ID: <20150518164242.GB12138@sudip-PC> (raw)
In-Reply-To: <1431966363.2870.24.camel@perches.com>
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > setup_timer is used for timer parameter setup rather than direct
> > > assignment
> > >
> > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> >
> > your From: name and Signed-off-by: names are not matching. They should
> > be same.
>
> If there's a specific "From: " in the _body_ of the email,
> that's true, but the sender email "From: " header and the
> Signed-off-by: line do not have to match.
But Greg usually rejects these patches where the sender "From:" header
and Signed-off-by: doesnot match. Just for example:
https://lkml.org/lkml/2014/11/25/924
regards
sudip
>
> A "From: " line in the email body should only be used when
> the patch is from a different sender than the sign-off.
>
>
next prev parent reply other threads:[~2015-05-18 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:44 [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 16:26 ` Joe Perches
2015-05-18 16:42 ` Sudip Mukherjee [this message]
2015-05-31 0:26 ` gregkh
2015-05-18 17:49 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518164242.GB12138@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdhanapa@visteon.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kolbeinnkarls@gmail.com \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdcasey@chabloom.com \
--cc=vbabu3@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox