From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbbESFFE (ORCPT ); Tue, 19 May 2015 01:05:04 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35452 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbbESFFA (ORCPT ); Tue, 19 May 2015 01:05:00 -0400 Date: Tue, 19 May 2015 10:33:26 +0530 From: Sudip Mukherjee To: Douglas Figueiredo Cc: Greg Kroah-Hartman , vitaly.osipov@gmail.com, matt@ninezulu.com, tapaswenipathak@gmail.com, artemiyv@acm.org, raghav3276@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge Message-ID: <20150519050326.GB3820@sudip-PC> References: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote: > From: douglasbsf > > Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c 1) mention which coding style problem you fixed in the commit message. 2) no need to mention the challenge in the subject, the subject can be something like [PATCH] staging: wlan-ng: fix long line 3) when you are sending a single patch, no need to mention 1/1 and what is that 930672e8693a? my guess its your commit id in your local git. No need to mention that also. regards sudip