From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbbESFe3 (ORCPT ); Tue, 19 May 2015 01:34:29 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:34275 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbbESFe1 (ORCPT ); Tue, 19 May 2015 01:34:27 -0400 Date: Tue, 19 May 2015 11:04:19 +0530 From: Sudip Mukherjee To: Pedro Marzo Perez Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init Message-ID: <20150519053419.GC3820@sudip-PC> References: <1431991944-16924-1-git-send-email-marzo.pedro@gmail.com> <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431991944-16924-2-git-send-email-marzo.pedro@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. I would have split this patch into three. 1) introduce pr_fmt and remove "ieee80211_crypt_wep" from pr_debug 2) return NULL instead of that goto fail. 3) combine two pr_debug into a single at the fail block. But Dan can say if its ok. (I am still taking ideas from Dan about my patches) regards sudip > > Signed-off-by: Pedro Marzo Perez