Re: [patch 3/6] x86, perf, cqm: Remove pointless spinlock from state cache

Matt Fleming
2015-05-19T09:23:03Z

On Tue, 19 May, at 12:00:53AM, Thomas Gleixner wrote:
> struct intel_cqm_state is a strict per cpu cache of the rmid and the
> usage counter. It can never be modified from a remote cpu.
>
> The 3 functions which modify the content: start, stop and del (del
> maps to stop) are called from the perf core with interrupts disabled
> which is enough protection for the per cpu state values.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> arch/x86/kernel/cpu/perf_event_intel_cqm.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)

The state locking code was taken from Peter's original patch last year,
so it would be good for him to chime in that this is safe. It's probably
just that it was necessary in Peter's patches but after I refactored
bits I forgot to rip it out.

But yeah, from reading the code again the lock does look entirely
superfluous.

So unless Peter complains,

Acked-by: Matt Fleming <matt.fleming@intel.com>

--
Matt Fleming, Intel Open Source Technology Center