Re: [PATCH v5 WIP 2/5] staging: panel: use new parport device model

[Dan Carpenter <dan.carpenter@oracle.com>]

On Wed, May 06, 2015 at 03:46:14PM +0530, Sudip Mukherjee wrote:
> converted to use the new device-model parallel port.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/staging/panel/panel.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 1d8ed8b..772a82a 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -2188,6 +2188,18 @@ static struct notifier_block panel_notifier = {
>  	0
>  };
>  
> +static int panel_probe(struct pardevice *par_dev)
> +{
> +	if (strcmp(par_dev->name, "panel"))
> +		return -ENODEV;
> +	return 0;
> +}
> +
> +struct pardev_cb panel_cb = {
> +	.flags = 0,     /*PARPORT_DEV_EXCL */

I don't understand this comment.  PARPORT_DEV_EXCL is BIT(2).  Update:
Oh, I see this comment is just copied from the earlier code and probably
means that it maybe should be set to PARPORT_DEV_EXCL.  Just put
something like this:

	.flags = 0,     /* should be PARPORT_DEV_EXCL? */

regards,
dan carpenter