From: Peter Zijlstra <peterz@infradead.org>
To: Sarbojit Ganguly <ganguly.s@samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"Waiman.Long@hp.com" <Waiman.Long@hp.com>,
"raghavendra.kt@linux.vnet.ibm.com"
<raghavendra.kt@linux.vnet.ibm.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
SHARAN ALLUR <sharan.allur@samsung.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"vikram.m@samsung.com" <vikram.m@samsung.com>
Subject: Re: [RFC] arm: Add for atomic half word exchange
Date: Tue, 19 May 2015 14:43:33 +0200 [thread overview]
Message-ID: <20150519124333.GC3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1795987946.405311432034410830.JavaMail.weblogic@ep2mlwas07a>
On Tue, May 19, 2015 at 11:20:13AM +0000, Sarbojit Ganguly wrote:
> On Tuesday 19 May 2015 09:39:33 Sarbojit Ganguly wrote:
> > Since 16 bit half word exchange was not there and MCS based
> > qspinlock by Waiman's xchg_tail() requires an atomic exchange on a
> > half word, here is a small modification to __xchg() code.
Can you actually see a performance improvement with the qspinlock code
on ARM ?
The real improvements on x86 were on NUMA systems; although there were
real improvements on light loads as well.
Note that ARM (or any load-store arch) could get rid of all the cmpxchg
loops in that code. Although I suppose we replaced the most common ones
with these unconditional atomics already -- like that xchg16 -- so
implementing those with ll/sc, as you did, should be near optimal.
next prev parent reply other threads:[~2015-05-19 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 11:20 [RFC] arm: Add for atomic half word exchange Sarbojit Ganguly
2015-05-19 11:42 ` Arnd Bergmann
2015-05-19 12:13 ` Russell King - ARM Linux
2015-05-19 12:43 ` Peter Zijlstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-05 1:17 Re: " Sarbojit Ganguly
2015-06-05 12:33 ` Arnd Bergmann
2015-06-02 6:21 Sarbojit Ganguly
2015-06-02 10:49 ` Arnd Bergmann
2015-06-02 5:49 Sarbojit Ganguly
2015-06-02 6:11 ` Raghavendra K T
2015-05-20 5:09 Sarbojit Ganguly
2015-05-20 6:51 ` Arnd Bergmann
2015-05-19 9:39 Sarbojit Ganguly
2015-05-19 9:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519124333.GC3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Waiman.Long@hp.com \
--cc=arnd@arndb.de \
--cc=ganguly.s@samsung.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=sharan.allur@samsung.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vikram.m@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox