From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965008AbbESPAe (ORCPT ); Tue, 19 May 2015 11:00:34 -0400 Received: from casper.infradead.org ([85.118.1.10]:53887 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932957AbbESPA2 (ORCPT ); Tue, 19 May 2015 11:00:28 -0400 Date: Tue, 19 May 2015 17:00:26 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Len Brown Subject: Re: [PATCH 2/2] PM / sleep: Make ->enter_freeze callbacks depend on CONFIG_SUSPEND Message-ID: <20150519150026.GE3644@twins.programming.kicks-ass.net> References: <7138791.PFSSF2gqXk@vostro.rjw.lan> <2834114.lD6BFXhtqK@vostro.rjw.lan> <20150518121826.GG21418@twins.programming.kicks-ass.net> <4721283.2H3KXdSq7L@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4721283.2H3KXdSq7L@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2015 at 11:45:10PM +0200, Rafael J. Wysocki wrote: > On Monday, May 18, 2015 02:18:26 PM Peter Zijlstra wrote: > > On Sat, May 16, 2015 at 01:38:48AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > The ->enter_freeze callbacks of cpuidle drivers are only used if > > > CONFIG_SUSPEND is set, so make them explicitly depend on that > > > Kconfig option. > > > > No real objection, but is it worth it to sprinkle that CONFIG stuff over > > all drivers? > > Well, you maybe right that it isn't. The footprint is small anyway. > > What about [1/2]? 1/2 looks fine to me.