From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: ming.lei@canonical.com, gregkh@linuxfoundation.org, tiwai@suse.de
Cc: rusty@rustcorp.com.au, torvalds@linux-foundation.org,
dhowells@redhat.com, seth.forshee@canonical.com,
linux-kernel@vger.kernel.org, pebolle@tiscali.nl,
linux-wireless@vger.kernel.org, gregkh@linuxfoundation.org,
jlee@suse.com, tiwai@suse.de,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH v3 0/4] firmware: few fixes for name uses
Date: Tue, 19 May 2015 18:45:33 +0200 [thread overview]
Message-ID: <20150519164533.GF23057@wotan.suse.de> (raw)
In-Reply-To: <1431467383-28540-1-git-send-email-mcgrof@do-not-panic.com>
On Tue, May 12, 2015 at 02:49:39PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> This v3 changes patch 1 to just return -ENOMEM and remove the
> unlikely() optimization. It also drops the early truncation
> checks.
>
> Luis R. Rodriguez (4):
> firmware: fix __getname() missing failure check
> firmware: check for file truncation on direct firmware loading
> firmware: fix possible use after free on name on asynchronous request
> firmware: use const for remaining firmware names
>
> drivers/base/firmware_class.c | 61 +++++++++++++++++++++++++++++++------------
> 1 file changed, 45 insertions(+), 16 deletions(-)
Ming, a review would be much appreciated. I also have a few other changes coming
later, so should these go through Greg or Takashi first ? If its of any help
I'm happy to take on co-maintenance on this module given that I am lookng
to do quite a bit of surgery on the APIs later.
Luis
next prev parent reply other threads:[~2015-05-19 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:49 [PATCH v3 0/4] firmware: few fixes for name uses Luis R. Rodriguez
2015-05-12 21:49 ` [PATCH v3 1/4] firmware: fix __getname() missing failure check Luis R. Rodriguez
2015-05-12 21:49 ` [PATCH v3 2/4] firmware: check for file truncation on direct firmware loading Luis R. Rodriguez
2015-05-12 21:49 ` [PATCH v3 3/4] firmware: fix possible use after free on name on asynchronous request Luis R. Rodriguez
2015-05-12 21:49 ` [PATCH v3 4/4] firmware: use const for remaining firmware names Luis R. Rodriguez
2015-05-19 16:45 ` Luis R. Rodriguez [this message]
2015-05-19 17:05 ` [PATCH v3 0/4] firmware: few fixes for name uses Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519164533.GF23057@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=ming.lei@canonical.com \
--cc=pebolle@tiscali.nl \
--cc=rusty@rustcorp.com.au \
--cc=seth.forshee@canonical.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox