public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rob Herring <robherring2@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2] drivers: of/base: move of_init to driver_init
Date: Tue, 19 May 2015 10:17:32 -0700	[thread overview]
Message-ID: <20150519171732.GD9213@kroah.com> (raw)
In-Reply-To: <555B2C9C.1000709@arm.com>

On Tue, May 19, 2015 at 01:29:16PM +0100, Sudeep Holla wrote:
> Hi Rob/Greg,
> 
> On 14/05/15 15:28, Sudeep Holla wrote:
> >Commit 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >devices with an OF node") adds the symlink `of_node` for each device
> >pointing to it's device tree node while creating/initialising it.
> >
> >However the devicetree sysfs is created and setup in of_init which is
> >executed at core_initcall level. For all the devices created before
> >of_init, the following error is thrown:
> >	"Error -2(-ENOENT) creating of_node link"
> >
> >Like many other components in driver model, initialize the sysfs support
> >for OF/devicetree from driver_init so that it's ready before any devices
> >are created.
> >
> >Fixes: 5590f3196b29 ("drivers/core/of: Add symlink to device-tree from
> >	devices with an OF node")
> >Suggested-by: Rob Herring <robh+dt@kernel.org>
> >Cc: Grant Likely <grant.likely@linaro.org>
> >Cc: Rob Herring <robh+dt@kernel.org>
> >Cc: Pawel Moll <pawel.moll@arm.com>
> >Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> 
> I assume one of you will pick this up if there are no further comments ?

I will once things settle down...

  reply	other threads:[~2015-05-19 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  9:28 [PATCH] drivers: of/base: move of_init to driver_init Sudeep Holla
2015-05-14 13:54 ` Sudeep Holla
2015-05-14 14:28 ` [PATCH v2] " Sudeep Holla
2015-05-19 12:29   ` Sudeep Holla
2015-05-19 17:17     ` Greg Kroah-Hartman [this message]
2015-05-20  9:22       ` Sudeep Holla
2015-06-07  7:05       ` Grant Likely
2015-06-08  0:29         ` Rob Herring
2015-06-08 15:19           ` Grant Likely
2015-05-20 13:15   ` Rob Herring
2015-05-22  6:46   ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519171732.GD9213@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Pawel.Moll@arm.com \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox