From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com,
"'Igor Grinberg'" <grinberg@compulab.co.il>
Subject: Re: [V2] rtc: rtc-v3020: use gpio_request_array()
Date: Wed, 20 May 2015 00:11:09 +0200 [thread overview]
Message-ID: <20150519221109.GD3338@piout.net> (raw)
In-Reply-To: <008a01ce10a3$02d28db0$0877a910$%han@samsung.com>
On 22/02/2013 at 11:19:15 +0900, Jingoo Han wrote :
> Using gpio_request_array()/gpio_free_array() can make the code
> simpler because it can set the direction and initial value
> in one shot and the for loop is unnecessary.
>
> Also, struct v3020_gpio is removed, because the struct v3020_gpio
> is replaced with struct gpio.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v1:
> - Replace gpio_request_one() with gpio_request_array()
>
> drivers/rtc/rtc-v3020.c | 37 ++++++++++++-------------------------
> 1 files changed, 12 insertions(+), 25 deletions(-)
>
Applied with the change suggested by Igor, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-19 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 8:31 [PATCH] rtc: rtc-v3020: use gpio_request_one() Jingoo Han
2013-02-21 8:48 ` Igor Grinberg
2013-02-22 2:13 ` Jingoo Han
2013-02-22 2:19 ` [PATCH V2] rtc: rtc-v3020: use gpio_request_array() Jingoo Han
2013-02-24 8:48 ` Igor Grinberg
2015-05-19 22:11 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519221109.GD3338@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=grinberg@compulab.co.il \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox