From: josh@joshtriplett.org
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Iulia Manda <iulia.manda21@gmail.com>,
tim.bird@sonymobile.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] kernel: Add a new config option to remove command line parsing
Date: Tue, 19 May 2015 17:54:04 -0700 [thread overview]
Message-ID: <20150520005404.GB32153@cloud> (raw)
In-Reply-To: <1432028159.9091.63.camel@x220>
On Tue, May 19, 2015 at 11:35:59AM +0200, Paul Bolle wrote:
> On Mon, 2015-05-18 at 14:50 +0300, Iulia Manda wrote:
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
>
> > +config CMDLINE_PARSE
> > + bool "Enable support for command line parsing"
> > + default y
> > + ---help---
> > + With this option set to 'Y', kernel parameters, both the ones
> > + passed at boot time and at compile time are parsed.
> > +
> > + If you say no here, all the kernel parameters' values will be set
> > + to their defaults at compile time, in order to make constant
> > + folding possible.
> > +
> > + Systems with no space constraints should leave this option set to
> > + 'Y'.
>
> This adds a x86 specific Kconfig option.
Good catch. I reviewed the Kconfig option and its usage very carefully,
but completely missed that it was in the wrong file.
This needs to go in init/Kconfig or similar.
- Josh Triplett
next prev parent reply other threads:[~2015-05-20 0:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 11:50 [PATCH 1/3] kernel: Add a new config option to remove command line parsing Iulia Manda
2015-05-18 11:50 ` [PATCH 2/3] linux: Add macros that define and declare a core_param variable Iulia Manda
2015-05-18 11:50 ` [PATCH 3/3] init: Set initcall_debug to a default value Iulia Manda
2015-05-19 9:46 ` Paul Bolle
2015-05-20 0:54 ` josh
2015-05-19 9:35 ` [PATCH 1/3] kernel: Add a new config option to remove command line parsing Paul Bolle
2015-05-20 0:54 ` josh [this message]
2015-05-20 6:29 ` Rob Landley
2015-05-20 15:15 ` [PATCH v2] " Iulia Manda
[not found] <1427898893-8257-1-git-send-email-iulia.manda21@gmail.com>
2015-04-09 14:44 ` [PATCH 1/3] " Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520005404.GB32153@cloud \
--to=josh@joshtriplett.org \
--cc=iulia.manda21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=tim.bird@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox