From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbbETBlk (ORCPT ); Tue, 19 May 2015 21:41:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41065 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbbETBlf (ORCPT ); Tue, 19 May 2015 21:41:35 -0400 Date: Tue, 19 May 2015 18:41:33 -0700 From: Stephen Boyd To: Ricky Liang Cc: Mike Turquette , Matthias Brugger , Henry Chen , Sascha Hauer , James Liao , "open list:COMMON CLK FRAMEWORK" , open list , "moderated list:ARM/Mediatek SoC..." , "moderated list:ARM/Mediatek SoC..." Subject: Re: [PATCH v3] clk: mediatek: Initialize clk_init_data Message-ID: <20150520014133.GE31054@codeaurora.org> References: <1431957632-2182-1-git-send-email-jcliang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431957632-2182-1-git-send-email-jcliang@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18, Ricky Liang wrote: > The variable init (struct clk_init_data) is allocated on the stack. > We weren't initializing the .flags field, so it contains random junk, > which can cause all kinds of interesting issues when the flags are > parsed by clk_register. > > Signed-off-by: Ricky Liang > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project