From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbbETFCT (ORCPT ); Wed, 20 May 2015 01:02:19 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33048 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbbETFCR (ORCPT ); Wed, 20 May 2015 01:02:17 -0400 Date: Wed, 20 May 2015 10:32:04 +0530 From: Sudip Mukherjee To: Amaury Denoyelle Cc: Ian Abbott , Greg Kroah-Hartman , H Hartley Sweeten , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c Message-ID: <20150520050204.GA4764@sudip-PC> References: <20150519054750.GD3820@sudip-PC> <1432058270-16752-1-git-send-email-amaury.denoyelle@gmail.com> <1432058270-16752-2-git-send-email-amaury.denoyelle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432058270-16752-2-git-send-email-amaury.denoyelle@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote: > This patch fixes coding style errors reported by checkpatch.pl for > cb_pcidas64.c, about too long source code lines. > > Signed-off-by: Amaury Denoyelle > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index a94c33c..f1bba2b 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev, > return devpriv->ai_fifo_segment_length; > } > > -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */ > +/* > + * adjusts the size of hardware fifo (which determines block size for dma xfers) > + */ I did not understand this one. You are not breaking the comment into two lines, then why multiline style? > const struct pcidas64_board *thisboard = dev->board_ptr; > @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev) > "Use internal AI channel queue (channels must be consecutive and use same range/aref)\n"); > } > > -/* Their i2c requires a huge delay on setting clock or data high for some reason */ > +/* > + * their i2c requires a huge delay on setting clock or data high for some reason > + */ same here. regards sudip