From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbbETIdb (ORCPT ); Wed, 20 May 2015 04:33:31 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34793 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbETId0 (ORCPT ); Wed, 20 May 2015 04:33:26 -0400 Date: Wed, 20 May 2015 14:03:13 +0530 From: Sudip Mukherjee To: Jean Delvare Cc: Greg KH , Dan Carpenter , One Thousand Gnomes , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 WIP 5/5] paride: use new parport device model Message-ID: <20150520083313.GA3166@sudip-PC> References: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com> <1430907377-17147-5-git-send-email-sudipm.mukherjee@gmail.com> <20150520100748.06c2eeed@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150520100748.06c2eeed@endymion.delvare> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2015 at 10:07:48AM +0200, Jean Delvare wrote: > Hi Sudip, > > On Wed, 6 May 2015 15:46:17 +0530, Sudip Mukherjee wrote: > > modify paride driver to use the new parallel port device model. > > Leading capital please ;-) yes, its the linux habit of writing in small letters. :) > > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > + } > > + par_cb->flags = 0; > > + par_cb->wakeup = pi_wake_up; > > + par_cb->private = (void *)pi; > > + pi->pardev = parport_register_dev_model(port, pi->device, par_cb, > > + unit); > > If pi->device already includes the device number, and you are passing > it again as unit, won't you end up with odd names like pcd0.0, pcd1.1, > pcd2.2 etc? yes, it is. This is the only driver using parport where in the probe i had to use strncmp again. > > > parport_put_port(port); > > + kfree(par_cb); > > If you don't need par_cb anywhere else then you shouldn't be allocating > it dynamically. It's small enough to fit on the stack really. like you suggested, I will make it local in all the drivers. regards sudip. > > -- > Jean Delvare > SUSE L3 Support